[webkit-reviews] review granted: [Bug 106831] [Chromium] Move BlobRegistryProxy into WebCore : [Attachment 182631] Patch

[bugzilla-daemon at webkit.org]

Adam Barth <abarth at webkit.org> has granted Mark Pilgrim (Google)
<pilgrim at chromium.org>'s request for review:
Bug 106831: [Chromium] Move BlobRegistryProxy into WebCore
https://bugs.webkit.org/show_bug.cgi?id=106831

Attachment 182631: Patch
https://bugs.webkit.org/attachment.cgi?id=182631&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=182631&action=review


I think this is fine for a first patch.  There's more cleanup we can do to
better integrate BlobRegistryProxy with BlobRegistryImpl

> Source/WebCore/platform/network/chromium/BlobRegistryProxy.cpp:48
> +// We are part of the WebKit implementation.
> +using namespace WebKit;

As in the other patch, it would be better to remove this using directive and be
explicit about when we're using things in the WebKit namespace.

> Source/WebCore/platform/network/chromium/BlobRegistryProxy.cpp:52
> +BlobRegistry& blobRegistry()

It looks like this function is declared in
Source/WebCore/platform/network/BlobRegistry.h.  I wonder if we should put this
function in Source/WebCore/platform/network/BlobRegistryImpl.cpp?