[webkit-reviews] review granted: [Bug 106630] Blur the label background of a snapshotted plugin : [Attachment 182655] Patch

[bugzilla-daemon at webkit.org]

Simon Fraser (smfr) <simon.fraser at apple.com> has granted Dean Jackson
<dino at apple.com>'s request for review:
Bug 106630: Blur the label background of a snapshotted plugin
https://bugs.webkit.org/show_bug.cgi?id=106630

Attachment 182655: Patch
https://bugs.webkit.org/attachment.cgi?id=182655&action=review

------- Additional Comments from Simon Fraser (smfr) <simon.fraser at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=182655&action=review


> Source/WebCore/ChangeLog:13
> +	   slightly blur the snapshot behind the label so that it is more
clear. All the code
> +	   here is platform-neutral, but the treatment is specific to Mac.
Unfortunately I
> +	   couldn't find a better place to put the code (RenderThemeMac depends
on a bunch
> +	   of Objective C classes). The good news is that this operation is
probably
> +	   helpful to other ports, which would be a case of simply removing the
#if PLATFORM.

I don't think you need to make excuses for this being here.

> Source/WebCore/rendering/RenderSnapshottedPlugIn.cpp:228
> +    RefPtr<RenderSnapshottedPlugInBlurFilter> blurFilter =
RenderSnapshottedPlugInBlurFilter::create(5);

Please move the '5' into a named constant.