[webkit-reviews] review denied: [Bug 103952] Scroll gestures should not create wheel events : [Attachment 182634] patch for review, but some layout tests still to be added

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Jan 14 16:45:47 PST 2013


James Robinson <jamesr at chromium.org> has denied Terry Anderson
<tdanderson at chromium.org>'s request for review:
Bug 103952: Scroll gestures should not create wheel events
https://bugs.webkit.org/show_bug.cgi?id=103952

Attachment 182634: patch for review, but some layout tests still to be added
https://bugs.webkit.org/attachment.cgi?id=182634&action=review

------- Additional Comments from James Robinson <jamesr at chromium.org>
Ah, the new GestureScroll* types are pretty weird.  It looks like you're trying
to preserve the wheel-like behavior.  I would nuke it and your ENABLE() - the
wheel-based behavior is busted.  If you get rid of that, do you need any new
Gesture types?


More information about the webkit-reviews mailing list