[webkit-reviews] review granted: [Bug 106838] kill whole lighttpd process tree for chromium win : [Attachment 182658] Patch

[bugzilla-daemon at webkit.org]

Tony Chang <tony at chromium.org> has granted Dirk Pranke <dpranke at chromium.org>'s
request for review:
Bug 106838: kill whole lighttpd process tree for chromium win
https://bugs.webkit.org/show_bug.cgi?id=106838

Attachment 182658: Patch
https://bugs.webkit.org/attachment.cgi?id=182658&action=review

------- Additional Comments from Tony Chang <tony at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=182658&action=review


I think the change is a fine way to prevent the bot from hanging, but the test
run will still be junk because of too many timeouts.  It'll probably confuse
garden-o-matic a bit.

> Tools/ChangeLog:9
> +	   Land a speculative fix for lighttpd.exe hanging on some google
> +	   internal win bots; I think a test is causing a httpd server child
process to

I would remove internal since this is failing on the public build.chromium.org
too (the Win bots used by the gardening tools).

> Tools/Scripts/webkitpy/layout_tests/servers/http_server_unittest.py:36
> +from webkitpy.thirdparty.autoinstalled import unittest2 as unittest

I would make this change separately.