[webkit-reviews] review denied: [Bug 106769] [GTK] build-webkit fails if the jhbuild wrapper is not used : [Attachment 182555] Patch

[bugzilla-daemon at webkit.org]

Martin Robinson <mrobinson at webkit.org> has denied Sergio Villar Senin
<svillar at igalia.com>'s request for review:
Bug 106769: [GTK] build-webkit fails if the jhbuild wrapper is not used
https://bugs.webkit.org/show_bug.cgi?id=106769

Attachment 182555: Patch
https://bugs.webkit.org/attachment.cgi?id=182555&action=review

------- Additional Comments from Martin Robinson <mrobinson at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=182555&action=review


The build failure seems legitimate, so it should probably be fixed.

> Tools/Scripts/webkitdirs.pm:1967
> +    # Prefix the command with jhbuild run.
> +    my $jhbuildWrapper = jhbuildWrapperPrefixIfNeeded();
> +    unshift(@buildArgs, $jhbuildWrapper) if ($jhbuildWrapper ne "");
> +

Why not add a function like prefixWithJHBuildWrapperIfNeeded()?