[webkit-reviews] review granted: [Bug 106679] Move functions from NodeRareData to ElementRareData and other classes : [Attachment 182629] Addressed Ben's comments; merged to ToT

[bugzilla-daemon at webkit.org]

Benjamin Poulain <benjamin at webkit.org> has granted Ryosuke Niwa
<rniwa at webkit.org>'s request for review:
Bug 106679: Move functions from NodeRareData to ElementRareData and other
classes
https://bugs.webkit.org/show_bug.cgi?id=106679

Attachment 182629: Addressed Ben's comments; merged to ToT
https://bugs.webkit.org/attachment.cgi?id=182629&action=review

------- Additional Comments from Benjamin Poulain <benjamin at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=182629&action=review


> Source/WebCore/dom/Element.cpp:237
> +void Element::setTabIndexExplicitly(int tabIndex)

int -> short

> Source/WebCore/dom/NodeRareData.cpp:43
>  struct SameSizeAsNodeRareData {
>      void* m_pointer[4];
> -    unsigned m_indicesAndBitfields[2];
> -
>  #if ENABLE(MICRODATA)

It would be nice to have a similar compile assertion for ElementRareData.