[webkit-reviews] review denied: [Bug 93980] [WK2] Implement testRunner.setUseDeferredFrameLoading : [Attachment 173585] patch

[bugzilla-daemon at webkit.org]

Benjamin Poulain <benjamin at webkit.org> has denied Zoltan Nyul
<zoltan.nyul at intel.com>'s request for review:
Bug 93980: [WK2] Implement testRunner.setUseDeferredFrameLoading
https://bugs.webkit.org/show_bug.cgi?id=93980

Attachment 173585: patch
https://bugs.webkit.org/attachment.cgi?id=173585&action=review

------- Additional Comments from Benjamin Poulain <benjamin at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=173585&action=review


Thank you for looking into this.

> LayoutTests/platform/efl-wk2/TestExpectations:-199
> -# testRunner.setUseDeferredFrameLoading() is not implemented in WK2. Skipped
so it does not generate PNG results.
> -webkit.org/b/93980
http/tests/appcache/load-from-appcache-defer-resume-crash.html [ Skip ]
> -

What about gtk-wk2?

> Tools/WebKitTestRunner/InjectedBundle/TestRunner.h:116
> +    // The InjectedBundle is already asynchronous so we don't need to
implement it
> +    void setUseDeferredFrameLoading(bool) { }

Doing that would be wrong. Any future test that would do
"setUseDeferredFrameLoading(false)" would use an unimplemented feature.
(What you could have done instead is rename the method so that it can only be
set. E.g. forceDeferredFrameLoading().)

I also think not doing anything is probably wrong. WebPage seems to have an API
for deferredFrameLoading: WebPage::setDefersLoading().