[webkit-reviews] review granted: [Bug 106271] Sometimes RenderLayer::updateNeedsCompositedScrolling not called : [Attachment 182444] Slightly simplified

[bugzilla-daemon at webkit.org]

Simon Fraser (smfr) <simon.fraser at apple.com> has granted Xianzhu Wang
<wangxianzhu at chromium.org>'s request for review:
Bug 106271: Sometimes RenderLayer::updateNeedsCompositedScrolling not called
https://bugs.webkit.org/show_bug.cgi?id=106271

Attachment 182444: Slightly simplified
https://bugs.webkit.org/attachment.cgi?id=182444&action=review

------- Additional Comments from Simon Fraser (smfr) <simon.fraser at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=182444&action=review


> Source/WebCore/rendering/RenderLayer.cpp:5547
> +    if (shouldBeScrollableArea != frameView->containsScrollableArea(this)) {

> +	   if (shouldBeScrollableArea)
> +	       frameView->addScrollableArea(this);
> +	   else
> +	       frameView->removeScrollableArea(this);

This is two hash lookups in either case. Would better if you could reduce it to
one.