[webkit-reviews] review denied: [Bug 103034] [WK2] Remove duplicated converting codes for zoomable area. : [Attachment 181260] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Mon Jan 14 13:58:50 PST 2013
Benjamin Poulain <benjamin at webkit.org> has denied EunMi Lee
<eunmi15.lee at samsung.com>'s request for review:
Bug 103034: [WK2] Remove duplicated converting codes for zoomable area.
https://bugs.webkit.org/show_bug.cgi?id=103034
Attachment 181260: Patch
https://bugs.webkit.org/attachment.cgi?id=181260&action=review
------- Additional Comments from Benjamin Poulain <benjamin at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=181260&action=review
> Source/WebKit2/ChangeLog:12
> + The zoomable area is converted to window in the TouchAdjustment's
> + findNodeWithLowestDistanceMetric() function, but it is converted
again
> + in the findZoomableAreaForPoint() of WebPage.cpp.
> + The converting is duplicated, so we can not get the correct zoomable
> + area of sub frame.
This looks correct.
I r- for the lack of test.
If there is no way to test test, please describe why in the ChangeLog.
More information about the webkit-reviews
mailing list