[webkit-reviews] review denied: [Bug 106763] [EFL][WK2][WebGL] Delay release of canvas shared objects until they are release on UI side. : [Attachment 182523] Patch

[bugzilla-daemon at webkit.org]

Benjamin Poulain <benjamin at webkit.org> has denied Viatcheslav Ostapenko
<ostap73 at gmail.com>'s request for review:
Bug 106763: [EFL][WK2][WebGL] Delay release of canvas shared objects until they
are release on UI side.
https://bugs.webkit.org/show_bug.cgi?id=106763

Attachment 182523: Patch
https://bugs.webkit.org/attachment.cgi?id=182523&action=review

------- Additional Comments from Benjamin Poulain <benjamin at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=182523&action=review


> Source/WebCore/platform/graphics/GraphicsContext3D.h:1098
>      friend class GraphicsContext3DPrivate;
> -    OwnPtr<GraphicsContext3DPrivate> m_private;
> +    RefPtr<GraphicsContext3DPrivate> m_private;

This looks wrong. Why have a shared ownership of a Private object?

Please explain this in the ChangeLog.