[webkit-reviews] review denied: [Bug 105337] Expose mutation observers to chromium : [Attachment 180057] update change log with more detailed description

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Jan 14 13:36:42 PST 2013


Adam Barth <abarth at webkit.org> has denied Dane Walllinga
<dgwallinga at chromium.org>'s request for review:
Bug 105337: Expose mutation observers to chromium
https://bugs.webkit.org/show_bug.cgi?id=105337

Attachment 180057: update change log with more detailed description
https://bugs.webkit.org/attachment.cgi?id=180057&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
> We'll need to create mutation observers for a whitelisted set of web pages
belonging to multipage autofill flows (for a related bug on the chromium side,
maybe check https://codereview.chromium.org/11539003/). Basically we need to be
able to support autofill behavior on pages with ajax-y stuff, which means
knowing when dom changes happen so we can query the autofill server again.
Initially maybe around 20 sites, though potentially more going forward. You are
correct that this could have some performance impact on dom operations, but the
improvements to autofill should speed up the user experience overall.

This approach sounds problematic.  What happens when we expand beyond this
whitelisted set of sites?

Perhaps WebKit should provide more detailed callbacks to notify you of when
things of interest happen in a web page.  MutationObserver sounds like too
general a mechanism for your needs.

I wonder if we should think more carefully about how to divide the
implementation of this feature between WebKit and Chromium.


More information about the webkit-reviews mailing list