[webkit-reviews] review requested: [Bug 105667] Enable reuse of cached main resources : [Attachment 182606] Address darin's comments

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Jan 14 11:57:37 PST 2013


Nate Chapin <japhet at chromium.org> has asked  for review:
Bug 105667: Enable reuse of cached main resources
https://bugs.webkit.org/show_bug.cgi?id=105667

Attachment 182606: Address darin's comments
https://bugs.webkit.org/attachment.cgi?id=182606&action=review

------- Additional Comments from Nate Chapin <japhet at chromium.org>
* Added some missing symbols for win and gtk.
* Made CachedRawResource::canReuse() virtual with a simple version on
CachedResource to make the casting safer.
* Renamed m_substituteDataLoadIdentifier to better match its usage
* Reworked comments and reorder some code to try to make things clearer


More information about the webkit-reviews mailing list