[webkit-reviews] review granted: [Bug 106674] [CSS Filters] brightness() function doesn't work as specified : [Attachment 182495] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Jan 14 10:40:29 PST 2013


Dean Jackson <dino at apple.com> has granted Dirk Schulze <krit at webkit.org>'s
request for review:
Bug 106674: [CSS Filters] brightness() function doesn't work as specified
https://bugs.webkit.org/show_bug.cgi?id=106674

Attachment 182495: Patch
https://bugs.webkit.org/attachment.cgi?id=182495&action=review

------- Additional Comments from Dean Jackson <dino at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=182495&action=review


I guess we should still have a test for values below 0 since we accept them.

> LayoutTests/css3/filters/script-tests/filter-property-parsing.js:331
> +testFilterRule("Parameter less then -100%",

Typo "than"

> LayoutTests/css3/filters/script-tests/filter-property-parsing.js:336
> +testFilterRule("Parameter more then 100%",

Ditto.


More information about the webkit-reviews mailing list