[webkit-reviews] review denied: [Bug 106801] Web Inspector: highlight regexp API for DefaultTextEditor : [Attachment 182593] Patch

[bugzilla-daemon at webkit.org]

Pavel Feldman <pfeldman at chromium.org> has denied Andrey Lushnikov
<lushnikov at chromium.org>'s request for review:
Bug 106801: Web Inspector: highlight regexp API for DefaultTextEditor
https://bugs.webkit.org/show_bug.cgi?id=106801

Attachment 182593: Patch
https://bugs.webkit.org/attachment.cgi?id=182593&action=review

------- Additional Comments from Pavel Feldman <pfeldman at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=182593&action=review


Please rename Regexp into Regex in method names.

> Source/WebCore/inspector/front-end/DefaultTextEditor.js:116
> +    highlightRegexp: function(regexp, cssClass)

highlightRegex

> Source/WebCore/inspector/front-end/DefaultTextEditor.js:1961
> +		   offsetTop: spans[i].offsetTop,

nuke

> Source/WebCore/inspector/front-end/DefaultTextEditor.js:1963
> +		   offsetHeight: spans[i].offsetHeight

nuke

> Source/WebCore/inspector/front-end/DefaultTextEditor.js:1980
> +	       highlight.style.marginTop = (metrics[i].offsetTop -
highlight.offsetTop) + "px";

nuke

> Source/WebCore/inspector/front-end/DefaultTextEditor.js:2054
> +		   if (!this._highlightRegexps.hasOwnProperty(key))

This is always false.