[webkit-reviews] review granted: [Bug 106800] [V8] Make an Isolate parameter mandatory in SerializedScriptValue methods : [Attachment 182588] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Jan 14 09:26:20 PST 2013


Adam Barth <abarth at webkit.org> has granted Kentaro Hara
<haraken at chromium.org>'s request for review:
Bug 106800: [V8] Make an Isolate parameter mandatory in SerializedScriptValue
methods
https://bugs.webkit.org/show_bug.cgi?id=106800

Attachment 182588: Patch
https://bugs.webkit.org/attachment.cgi?id=182588&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=182588&action=review


Ok, but we should be able to remove the non-isolate version of many of these
methods once we've updated all the callers.  (Notice that the JSC versions pass
an ExecState.)

> Source/WebCore/ChangeLog:10
> +	   SerializedScriptValue methods are used by both V8 bindings
> +	   and WebCore. So they should support both an Isolate-version
> +	   method and an non-Isolate version method.

The JSC version needs an ExecState, which plays a similar roll to the isolate
in the V8 version.

> Source/WebCore/ChangeLog:20
> +	   make sure that we never passe a 0 Isolate. If we take the approach

passe -> pass


More information about the webkit-reviews mailing list