[webkit-reviews] review denied: [Bug 106795] Web Inspector: Introduce file mapping allowing to map network loaded scripts and stylesheets to file system files. : [Attachment 182583] Patch

[bugzilla-daemon at webkit.org]

Pavel Feldman <pfeldman at chromium.org> has denied Vsevolod Vlasov
<vsevik at chromium.org>'s request for review:
Bug 106795: Web Inspector: Introduce file mapping allowing to map network
loaded scripts and stylesheets to file system files.
https://bugs.webkit.org/show_bug.cgi?id=106795

Attachment 182583: Patch
https://bugs.webkit.org/attachment.cgi?id=182583&action=review

------- Additional Comments from Pavel Feldman <pfeldman at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=182583&action=review


> Source/WebCore/inspector/front-end/BreakpointManager.js:453
> +	       var url =
WebInspector.fileMapping.urlForUISourceCode(this._primaryUILocation.uiSourceCod
e);

I think I like it more the way it was before. I.e. if each UISourceCode has
exactly one (or zero) URLs and that URL does not change during the UISourceCode
lifetime, why not to store it internally? External mapping just adds
indirection. Look at the way you bloat the code.