[webkit-reviews] review requested: [Bug 106798] ANGLE should build with -Wshorten-64-to-32 : [Attachment 182578] Patch

[bugzilla-daemon at webkit.org]

David Kilzer (:ddkilzer) <ddkilzer at webkit.org> has asked  for review:
Bug 106798: ANGLE should build with -Wshorten-64-to-32
https://bugs.webkit.org/show_bug.cgi?id=106798

Attachment 182578: Patch
https://bugs.webkit.org/attachment.cgi?id=182578&action=review

------- Additional Comments from David Kilzer (:ddkilzer) <ddkilzer at webkit.org>
<http://webkit.org/b/000000>

Reviewed by NOBODY (OOPS!).

* Configurations/Base.xcconfig: Enable -Wshorten-64-to-32 by
setting GCC_WARN_64_TO_32_BIT_CONVERSION to YES.
* src/compiler/MapLongVariableNames.cpp:
(LongNameMap::Size): Add static_cast<int>().
* src/compiler/ShaderLang.cpp: Ditto.
(getVariableInfo):
(ShGetInfo):
* src/compiler/ValidateLimitations.cpp:
(ValidateLimitations::validateFunctionCall): Change ParamIndex
from int to size_t.  Add static_cast<int>() when passing as
argument to getParam().
* src/compiler/glslang.l: Disable -Wshorten-64-to-32 by pragma.
* src/compiler/glslang_lex.cpp: Ditto.
* src/compiler/osinclude.h: Change type of OS_TLSIndex to
pthread_key_t.	Define OS_INVALID_TLS_INDEX by using
static_cast<OS_TLSIndex>(-1).
* src/compiler/preprocessor/new/Input.cpp:
(pp::Input::Input): Add static_cast<int>().
* src/compiler/preprocessor/new/Tokenizer.cpp: Disable
-Wshorten-64-to-32 by pragma.
* src/compiler/preprocessor/new/Tokenizer.l: Ditto.
* src/compiler/preprocessor/scanner.c:
(yylex_CPP): Add C-style (int) cast.
---
 12 files changed, 46 insertions(+), 10 deletions(-)