[webkit-reviews] review granted: [Bug 106771] [V8] Add m_isolate to ScriptController, WorkerScriptController and V8DOMWindowShell : [Attachment 182533] Patch

[bugzilla-daemon at webkit.org]

Adam Barth <abarth at webkit.org> has granted Kentaro Hara
<haraken at chromium.org>'s request for review:
Bug 106771: [V8] Add m_isolate to ScriptController, WorkerScriptController and
V8DOMWindowShell
https://bugs.webkit.org/show_bug.cgi?id=106771

Attachment 182533: Patch
https://bugs.webkit.org/attachment.cgi?id=182533&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=182533&action=review


> Source/WebCore/bindings/v8/ScriptController.cpp:105
> +    , m_isolate(v8::Isolate::GetCurrent())

Will the isolate have been created by then?  I guess the tests will tell us! 
:)

> Source/WebCore/bindings/v8/ScriptController.h:202
> +    v8::Isolate* m_isolate;

Can we hold onto the isolate forever?