[webkit-reviews] review denied: [Bug 106662] [EFL][GTK] checkSpellingOfString treats the multiple words as spelled correctly : [Attachment 182338] proposed patch

[bugzilla-daemon at webkit.org]

Sergio Villar Senin <svillar at igalia.com> has denied Grzegorz Czajkowski
<g.czajkowski at samsung.com>'s request for review:
Bug 106662: [EFL][GTK] checkSpellingOfString treats the multiple words as
spelled correctly
https://bugs.webkit.org/show_bug.cgi?id=106662

Attachment 182338: proposed patch
https://bugs.webkit.org/attachment.cgi?id=182338&action=review

------- Additional Comments from Sergio Villar Senin <svillar at igalia.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=182338&action=review


The problem is not in checkSpellingOfWord() but in checkSpellingOfString().
What happens in the test case you mention is that after considering that zz is
misspelled (and thus filling misspellingLocation and misspellingLength with the
proper values), then it processes the 3rd word which is correct and thus it
will overwrite the two variables with 0, -1, so the whole string will be
considered correct. What you have to do is exit if one of the words is wrong.

> Source/WebCore/platform/text/enchant/TextCheckerEnchant.cpp:78
>	   }

This is wrong, the word is OK if it's correct according to at least one
dictionary not the other way around.