[webkit-reviews] review denied: [Bug 106705] Web Inspector: add text editor formatter test : [Attachment 182428] Patch

[bugzilla-daemon at webkit.org]

Pavel Feldman <pfeldman at chromium.org> has denied Andrey Lushnikov
<lushnikov at chromium.org>'s request for review:
Bug 106705: Web Inspector: add text editor formatter test
https://bugs.webkit.org/show_bug.cgi?id=106705

Attachment 182428: Patch
https://bugs.webkit.org/attachment.cgi?id=182428&action=review

------- Additional Comments from Pavel Feldman <pfeldman at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=182428&action=review


> LayoutTests/inspector/editor/text-editor-formatter.html:12
> +    function enter() {

{ on the next line.

> LayoutTests/inspector/editor/text-editor-formatter.html:16
> +    function printLine(line) {

ditto and move this into editor-test.js InspectorTest.printEditorLine

> LayoutTests/inspector/editor/text-editor-formatter.html:24
> +    var textEditor = new WebInspector.DefaultTextEditor("", new
WebInspector.TextEditorDelegate());

You should use editor test's implementation.

> LayoutTests/inspector/editor/text-editor-formatter.html:26
> +    textEditor.mimeType="text/javascript";

mimeType =

> LayoutTests/inspector/editor/text-editor-formatter.html:51
> +    testRunner.closeWebInspector();

try calling InspectorFrontendHost.bringToFront instead.

> LayoutTests/inspector/editor/text-editor-formatter.html:68
> +function foo(n) {

declare it in test and use its toString().split("\n")