[webkit-reviews] review granted: [Bug 106754] Sheriffbot command aliases need test cases : [Attachment 182506] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Sun Jan 13 22:28:18 PST 2013
Eric Seidel <eric at webkit.org> has granted Alan Cutter
<alancutter at chromium.org>'s request for review:
Bug 106754: Sheriffbot command aliases need test cases
https://bugs.webkit.org/show_bug.cgi?id=106754
Attachment 182506: Patch
https://bugs.webkit.org/attachment.cgi?id=182506&action=review
------- Additional Comments from Eric Seidel <eric at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=182506&action=review
> Tools/Scripts/webkitpy/tool/commands/sheriffbot_unittest.py:43
> + tool = MockTool()
> + options = MockOptions()
> + options.ensure_value("confirm", False)
> + sheriffbot = SheriffBot()
> + sheriffbot.execute(options, [], tool, MockQueueEngine)
> + sheriffbot.begin_work_queue()
> + irc_bot = sheriffbot._irc_bot
Quite an epic amount of boiler plate. :)
More information about the webkit-reviews
mailing list