[webkit-reviews] review denied: [Bug 105787] [Qt][EFL][GTK][TexMap] Refactor code related to debug border and repaint count. : [Attachment 182266] Patch : [TexMap] Refactor code related to debug border and repaint count. [1/2]

[bugzilla-daemon at webkit.org]

Noam Rosenthal <noam at webkit.org> has denied Huang Dongsung
<luxtella at company100.net>'s request for review:
Bug 105787: [Qt][EFL][GTK][TexMap] Refactor code related to debug border and
repaint count.
https://bugs.webkit.org/show_bug.cgi?id=105787

Attachment 182266: Patch : [TexMap] Refactor code related to debug border and
repaint count. [1/2] 
https://bugs.webkit.org/attachment.cgi?id=182266&action=review

------- Additional Comments from Noam Rosenthal <noam at webkit.org>
In second thought, I think this is not a good direction.
By making it easy to add parameters to the paint functions, we make things easy
to silently regress in subclasses of TextureMapperPlatformLayer if we add more
parameters.

I prefer to even remove the mask parameters, and have that paint function
always be paintToTextureMapper(tm, rect, transform, opacity), giving the reset
of the control to the subclass, and add a TextureMapper::setMask/setDebugBorder
etc.