[webkit-reviews] review requested: [Bug 87548] check-webkit-style cannot running in Chinese windows. : [Attachment 182481] patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Sun Jan 13 02:14:07 PST 2013
huangxueqing <huangxueqing at baidu.com> has asked for review:
Bug 87548: check-webkit-style cannot running in Chinese windows.
https://bugs.webkit.org/show_bug.cgi?id=87548
Attachment 182481: patch
https://bugs.webkit.org/attachment.cgi?id=182481&action=review
------- Additional Comments from huangxueqing <huangxueqing at baidu.com>
The version info retrieved in Chinese Windows was "Microsoft Windows [版本
6.1.7601]", "版本"('version' in English) was encoded as "0xB0 0xE6 0xB1 0xBE" and
'0xB0' was not a valid utf-8 character, thus check-webkit-style running failed.
Actually, we execute "cmd /c ver" then use regular expression to match version
infomation, it's unnecessary to decode the output string of execution.
More information about the webkit-reviews
mailing list