[webkit-reviews] review denied: [Bug 104773] [EFL] Quit debug build without -DSHARED_CORE=ON : [Attachment 182280] Patch

[bugzilla-daemon at webkit.org]

Laszlo Gombos <laszlo.gombos at webkit.org> has denied Halton Huo
<halton.huo at gmail.com>'s request for review:
Bug 104773: [EFL] Quit debug build without -DSHARED_CORE=ON
https://bugs.webkit.org/show_bug.cgi?id=104773

Attachment 182280: Patch
https://bugs.webkit.org/attachment.cgi?id=182280&action=review

------- Additional Comments from Laszlo Gombos <laszlo.gombos at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=182280&action=review


r- to make sure that this patch is only applied to the EFL port.

> CMakeLists.txt:11
> +if (${CMAKE_BUILD_TYPE} MATCHES "^[Dd][Ee][Bb][Uu][Gg]$" AND NOT
SHARED_CORE)

As far as I can tell this rule is only needed for the EFL port, but this line
will be evaluated for all ports. Can we instead move this logic to
OptionsEfl.cmake ?

Can we use the following line instead before checking for the build type
string(TOLOWER ${CMAKE_BUILD_TYPE} CMAKE_BUILD_TYPE)

> CMakeLists.txt:12
> +    message(FATAL_ERROR "Debug build need set -DSHARED_CORE=ON")

How about 'Turn on the SHARED_CORE flag to make a debug build - e.g.
build-webkit --efl --debug --cmakeargs="-DSHARED_CORE=ON" ' as most people use
build-webkit.

My preference is option 2 as the only way to make a debug build and the moment
is using this option, so I do not see a problem automatically setting it for
debug builds, but both option 1 and option 2 is better than what we have now so
I do not have a strong preference.