[webkit-reviews] review granted: [Bug 106714] Clean up WebVTTNodeType code : [Attachment 182439] Patch

[bugzilla-daemon at webkit.org]

Tony Chang <tony at chromium.org> has granted Elliott Sprehn
<esprehn at chromium.org>'s request for review:
Bug 106714: Clean up WebVTTNodeType code
https://bugs.webkit.org/show_bug.cgi?id=106714

Attachment 182439: Patch
https://bugs.webkit.org/attachment.cgi?id=182439&action=review

------- Additional Comments from Tony Chang <tony at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=182439&action=review


> Source/WebCore/css/StyleResolver.cpp:657
> +    if (m_element->webVTTNodeType())

Nit: I would probably explicitly say != WebVTTNodeTypeNone or when declaring
the enum, set WebVTTNodeTypeNone = 0.

> Source/WebCore/dom/Element.cpp:2318
> +    return ensureElementRareData()->setWebVTTNodeType(type);

Nit: return not needed.

> Source/WebCore/dom/NodeRareData.h:401
> +    unsigned m_webVTTNodeType : 2;

Nit: In RenderStyle, we normally add an end-of-line comment with the enum name
so it's easier to verify that we've allocated enough space.