[webkit-reviews] review granted: [Bug 106617] Setting width overrides intrinsic min-width/max-width on flexboxes and their subclasses : [Attachment 182225] Patch

[bugzilla-daemon at webkit.org]

Tony Chang <tony at chromium.org> has granted Ojan Vafai <ojan at chromium.org>'s
request for review:
Bug 106617: Setting width overrides intrinsic min-width/max-width on flexboxes
and their subclasses
https://bugs.webkit.org/show_bug.cgi?id=106617

Attachment 182225: Patch
https://bugs.webkit.org/attachment.cgi?id=182225&action=review

------- Additional Comments from Tony Chang <tony at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=182225&action=review


> Source/WebCore/ChangeLog:9
> +	   classes that override computePrefferedLogicalWidths so that
RenderBox can use

Preffered -> Preferred

> Source/WebCore/rendering/RenderBox.cpp:2064
> +    if (logicalWidth.type() == FillAvailable)
> +	   return logicalWidthResult;
> +
> +    if (widthType == MainOrPreferredSize &&
sizesLogicalWidthToFitContent(widthType))

I see, you're saying that sizesLogicalWidthToFitContent doesn't make sense for
min-width or max-width, right?

I would probably have kept the != FillAvailable in the same condition, but this
seems OK too.