[webkit-reviews] review granted: [Bug 106675] Fixed width overrides intrinsic min-width/max-width for text inputs and listboxes : [Attachment 182363] Patch

[bugzilla-daemon at webkit.org]

Emil A Eklund <eae at chromium.org> has granted Ojan Vafai <ojan at chromium.org>'s
request for review:
Bug 106675: Fixed width overrides intrinsic min-width/max-width for text inputs
and listboxes
https://bugs.webkit.org/show_bug.cgi?id=106675

Attachment 182363: Patch
https://bugs.webkit.org/attachment.cgi?id=182363&action=review

------- Additional Comments from Emil A Eklund <eae at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=182363&action=review


>>> Source/WebCore/rendering/RenderListBox.cpp:208
>>> +	 maxLogicalWidth = m_optionsWidth + 2 * optionsSpacingHorizontal;
>> 
>> I know you are just moving this code but why are we doubling the horizontal
spacing here?
> 
> Not sure. We use optionsSpacingHorizontal elsewhere in the file without
doubling it though. As you said, I'm just moving the code.

Would you mind adding a FIXME?