[webkit-reviews] review granted: [Bug 106557] [V8] Do not create a local handle for a cached v8 string that is returned to V8 immediately : [Attachment 182284] Patch

[bugzilla-daemon at webkit.org]

Adam Barth <abarth at webkit.org> has granted Kentaro Hara
<haraken at chromium.org>'s request for review:
Bug 106557: [V8] Do not create a local handle for a cached v8 string that is
returned to V8 immediately
https://bugs.webkit.org/show_bug.cgi?id=106557

Attachment 182284: Patch
https://bugs.webkit.org/attachment.cgi?id=182284&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=182284&action=review


> Source/WebCore/bindings/scripts/test/V8/V8TestInterface.cpp:62
> +    return v8String(TestSupplemental::supplementalStaticAttr(),
info.GetIsolate(), ReturnPersistentHandle);

ReturnPersistentHandle -> ReturnWeakHandle? ReturnUnsafeHandle?

We want to pick a name that communicates the danger.  ReturnPersistentHandle
makes it sound like the hand that gets return is going to stick around
persistently, which is the opposite of the truth!