[webkit-reviews] review denied: [Bug 106650] Web Inspector: fix DRT to deliver simulated events to devtools front-end : [Attachment 182312] Patch

[bugzilla-daemon at webkit.org]

Pavel Feldman <pfeldman at chromium.org> has denied Andrey Lushnikov
<lushnikov at chromium.org>'s request for review:
Bug 106650: Web Inspector: fix DRT to deliver simulated events to devtools
front-end
https://bugs.webkit.org/show_bug.cgi?id=106650

Attachment 182312: Patch
https://bugs.webkit.org/attachment.cgi?id=182312&action=review

------- Additional Comments from Pavel Feldman <pfeldman at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=182312&action=review


> Tools/DumpRenderTree/chromium/TestRunner/public/WebTestProxy.h:77
>      void setInterfaces(WebTestInterfaces*);

I don't think you need this, just make interfaces private to the host and make
it own it.

> Tools/DumpRenderTree/chromium/TestRunner/public/WebTestProxy.h:78
> +    WebTestInterfaces *testInterfaces() const { return
m_testInterfaces.get(); }

WebTestInterfaces*

> Tools/DumpRenderTree/chromium/TestShell.cpp:386
> +    m_testRunner->setTestIsRunning(false);

What if testRunner is missing? Can it be?

> Tools/DumpRenderTree/chromium/TestShell.cpp:764
> +    WebTestInterfaces * testInterfaces = new WebTestInterfaces();

Just move this into the host constructor.