[webkit-reviews] review granted: [Bug 105856] Web Inspector: Workspace should support several projects and should not have temporary UISourceCodes. : [Attachment 182302] Patch

[bugzilla-daemon at webkit.org]

Pavel Feldman <pfeldman at chromium.org> has granted Vsevolod Vlasov
<vsevik at chromium.org>'s request for review:
Bug 105856: Web Inspector: Workspace should support several projects and should
not have temporary UISourceCodes.
https://bugs.webkit.org/show_bug.cgi?id=105856

Attachment 182302: Patch
https://bugs.webkit.org/attachment.cgi?id=182302&action=review

------- Additional Comments from Pavel Feldman <pfeldman at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=182302&action=review


> Source/WebCore/inspector/front-end/BreakpointManager.js:230
> +	   var project = event.data;

Cast annotation?

> Source/WebCore/inspector/front-end/CSSStyleModel.js:485
> +    _inspectedURLChanged: function(event)

This little refactoring looks like a separate change.

> Source/WebCore/inspector/front-end/FilteredItemSelectionDialog.js:622
> +	   if (projectName === WebInspector.projectNames.Debugger ||
projectName === WebInspector.projectNames.LiveEdit)

project.isServiceProject()

> Source/WebCore/inspector/front-end/LiveEditSupport.js:157
> +	   this.addFile(uniqueURI, url, contentProvider, isEditable);

I would do that in the call site.