[webkit-reviews] review granted: [Bug 106526] When a selected node in nested ShadowDOM is deleted, selection have wrong range. : [Attachment 182064] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Jan 10 20:01:05 PST 2013


Ryosuke Niwa <rniwa at webkit.org> has granted Shinya Kawanaka
<shinyak at chromium.org>'s request for review:
Bug 106526: When a selected node in nested ShadowDOM is deleted, selection have
wrong range.
https://bugs.webkit.org/show_bug.cgi?id=106526

Attachment 182064: Patch
https://bugs.webkit.org/attachment.cgi?id=182064&action=review

------- Additional Comments from Ryosuke Niwa <rniwa at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=182064&action=review


> LayoutTests/fast/dom/shadow/selection-in-nested-shadow-expected.txt:3
> +PASS anchorNode1 is container
> +PASS anchorNode2 is container
> +PASS successfullyParsed is true

This output isn't so helpful. Please give more descriptive variable names.


More information about the webkit-reviews mailing list