[webkit-reviews] review granted: [Bug 106614] [Shadow DOM] Refactoring: InsertionPoint could simplify its subclass hooks : [Attachment 182242] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Thu Jan 10 19:28:44 PST 2013
Dimitri Glazkov (Google) <dglazkov at chromium.org> has granted Hajime Morrita
<morrita at google.com>'s request for review:
Bug 106614: [Shadow DOM] Refactoring: InsertionPoint could simplify its
subclass hooks
https://bugs.webkit.org/show_bug.cgi?id=106614
Attachment 182242: Patch
https://bugs.webkit.org/attachment.cgi?id=182242&action=review
------- Additional Comments from Dimitri Glazkov (Google)
<dglazkov at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=182242&action=review
> Source/WebCore/html/shadow/InsertionPoint.h:54
> + MatchAccept,
> + MatchReject,
> + MatchSelect
I kind of like the longer names that explain what's happening (the ones that I
suggested).
More information about the webkit-reviews
mailing list