[webkit-reviews] review granted: [Bug 106619] Plugin snapshot label should take device resolution and inset into account : [Attachment 182227] Patch

[bugzilla-daemon at webkit.org]

Simon Fraser (smfr) <simon.fraser at apple.com> has granted Dean Jackson
<dino at apple.com>'s request for review:
Bug 106619: Plugin snapshot label should take device resolution and inset into
account
https://bugs.webkit.org/show_bug.cgi?id=106619

Attachment 182227: Patch
https://bugs.webkit.org/attachment.cgi?id=182227&action=review

------- Additional Comments from Simon Fraser (smfr) <simon.fraser at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=182227&action=review


> Source/WebCore/rendering/RenderSnapshottedPlugIn.cpp:46
> +static const int startLabelInset = 20; // But the label is inset from its
box also. FIXME: This will be removed when we go to a ShadowDOM approach.

That type of comment isn't very future-proof!