[webkit-reviews] review granted: [Bug 105489] Elements must be reattached when inserted/removed from top layer : [Attachment 181858] Patch

[bugzilla-daemon at webkit.org]

Julien Chaffraix <jchaffraix at webkit.org> has granted Matt Falkenhagen
<falken at chromium.org>'s request for review:
Bug 105489: Elements must be reattached when inserted/removed from top layer
https://bugs.webkit.org/show_bug.cgi?id=105489

Attachment 181858: Patch
https://bugs.webkit.org/attachment.cgi?id=181858&action=review

------- Additional Comments from Julien Chaffraix <jchaffraix at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=181858&action=review


> LayoutTests/ChangeLog:14
> +	   *
fast/dom/HTMLDialogElement/top-layer-stacking-dynamic-2-expected.html: Added.
> +	   * fast/dom/HTMLDialogElement/top-layer-stacking-dynamic-2.html:
Added.
> +	   This tests that top layer ordering is correct after removing and
readding an element to the top layer.

I prefer more explicit naming instead of "dynamic 2". Here:
top-layer-stacking-correct-order-remove-readd.html

>
LayoutTests/fast/dom/HTMLDialogElement/top-layer-stacking-dynamic-2-expected.ht
ml:13
> +    left: 0; right: 0;

For consistency, this should be split on 2 lines.