[webkit-reviews] review granted: [Bug 106527] Should be able to tell EWS tool cold-boot.sh what the boot screen script should be : [Attachment 182110] Patch

[bugzilla-daemon at webkit.org]

Adam Barth <abarth at webkit.org> has granted Alan Cutter
<alancutter at chromium.org>'s request for review:
Bug 106527: Should be able to tell EWS tool cold-boot.sh what the boot screen
script should be
https://bugs.webkit.org/show_bug.cgi?id=106527

Attachment 182110: Patch
https://bugs.webkit.org/attachment.cgi?id=182110&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=182110&action=review


> Tools/ChangeLog:10
> +	   Split cold-boot.sh script up into build-vm.sh, build-repo.sh and
build-boot-cmd.sh.
> +	   Updated GCE bot build scripts to match.
> +	   Unable to test scripts directly as they depend on being in the
repository to work!

Ideally a ChangeLog would explain the "why" behind a change rather than just
the "what" you're changing.  My guess is that you're making this change to
support building the style-queue and the sherrifbot on Google Compute Engine,
but it would be nice if you added that information here so that others can
understand your change too.