[webkit-reviews] review denied: [Bug 106557] [V8] Do not create a local handle for a cached v8 string that is returned to V8 immediately : [Attachment 182123] Patch

[bugzilla-daemon at webkit.org]

Adam Barth <abarth at webkit.org> has denied Kentaro Hara <haraken at chromium.org>'s
request for review:
Bug 106557: [V8] Do not create a local handle for a cached v8 string that is
returned to V8 immediately
https://bugs.webkit.org/show_bug.cgi?id=106557

Attachment 182123: Patch
https://bugs.webkit.org/attachment.cgi?id=182123&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=182123&action=review


> Source/WebCore/bindings/v8/V8Binding.h:148
> -    inline v8::Handle<v8::String> v8String(const String& string,
v8::Isolate* isolate = 0)
> +    inline v8::Handle<v8::String> v8String(const String& string,
v8::Isolate* isolate = 0, bool canReturnPersistentHandle = false)

Can we use an enum rather than a boolean parameter?  In this patch, the call
sites have this mysterious "true" at the end that's likely to be misunderstood
in the future.