[webkit-reviews] review granted: [Bug 106591] Flexboxes incorrectly add the scrollbar width to the intrinsic width of fixed-width items : [Attachment 182187] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Thu Jan 10 12:13:02 PST 2013
Levi Weintraub <leviw at chromium.org> has granted Ojan Vafai
<ojan at chromium.org>'s request for review:
Bug 106591: Flexboxes incorrectly add the scrollbar width to the intrinsic
width of fixed-width items
https://bugs.webkit.org/show_bug.cgi?id=106591
Attachment 182187: Patch
https://bugs.webkit.org/attachment.cgi?id=182187&action=review
------- Additional Comments from Levi Weintraub <leviw at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=182187&action=review
> Source/WebCore/ChangeLog:27
> + * rendering/RenderGrid.cpp:
> + (WebCore::RenderGrid::computePreferredLogicalWidths):
Nit: a short summary would be nice for the changes, especially calling out that
you're only adding a FIXME to RenderGrid.
More information about the webkit-reviews
mailing list