[webkit-reviews] review granted: [Bug 106584] Dashboard Cleanup: Do not generate the page if we are about to reload. : [Attachment 182173] Patch

[bugzilla-daemon at webkit.org]

Dirk Pranke <dpranke at chromium.org> has granted Julie Parent
<jparent at google.com>'s request for review:
Bug 106584: Dashboard Cleanup: Do not generate the page if we are about to
reload.
https://bugs.webkit.org/show_bug.cgi?id=106584

Attachment 182173: Patch
https://bugs.webkit.org/attachment.cgi?id=182173&action=review

------- Additional Comments from Dirk Pranke <dpranke at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=182173&action=review


> Tools/TestResultServer/static-dashboards/dashboard_base.js:-330
> -		   return {};

can you add a comment up at line 318 indicating that the function returns
whether to generate the page or not? The function name is slightly misleading
since it's now parsing parameters *and* telling you whether to generate the
page, but I can't think of a better function name that would capture that w/o
being awkward.