[webkit-reviews] review granted: [Bug 106548] [chromium] move webpermissionclient related methods to TestRunner library : [Attachment 182143] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Jan 10 08:21:25 PST 2013


jochen at chromium.org has granted Dan Carney <dcarney at google.com>'s request for
review:
Bug 106548: [chromium] move webpermissionclient related methods to TestRunner
library
https://bugs.webkit.org/show_bug.cgi?id=106548

Attachment 182143: Patch
https://bugs.webkit.org/attachment.cgi?id=182143&action=review

------- Additional Comments from jochen at chromium.org
very nice!

View in context: https://bugs.webkit.org/attachment.cgi?id=182143&action=review


> Tools/ChangeLog:65
> +	   (normalizeLayoutTestURLInternal):

please update the changelog

> Tools/DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:86
> +    , m_webPermissions(adoptPtr(new WebPermissions()))

nit no () required after WebPermissions


More information about the webkit-reviews mailing list