[webkit-reviews] review denied: [Bug 106475] Web Inspector: Correct formatting in inspector-test.js : [Attachment 181956] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Jan 10 05:47:50 PST 2013


Pavel Feldman <pfeldman at chromium.org> has denied johnjbarton
<johnjbarton at chromium.org>'s request for review:
Bug 106475: Web Inspector: Correct formatting in inspector-test.js
https://bugs.webkit.org/show_bug.cgi?id=106475

Attachment 181956: Patch
https://bugs.webkit.org/attachment.cgi?id=181956&action=review

------- Additional Comments from Pavel Feldman <pfeldman at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=181956&action=review


> LayoutTests/http/tests/inspector/inspector-test.js:333
> +    InspectorTest.addConsoleSniffer = function(override, opt_sticky)

As I mentioned, we don't indent namespaces / closures like this. Like this like
looks really weird now.


More information about the webkit-reviews mailing list