[webkit-reviews] review granted: [Bug 106383] ScrollingCoordinator touch event hit rects aren't converted to proper coordinates when in nested views : [Attachment 181771] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Jan 9 21:56:24 PST 2013


James Robinson <jamesr at chromium.org> has granted Levi Weintraub
<leviw at chromium.org>'s request for review:
Bug 106383: ScrollingCoordinator touch event hit rects aren't converted to
proper coordinates when in nested views
https://bugs.webkit.org/show_bug.cgi?id=106383

Attachment 181771: Patch
https://bugs.webkit.org/attachment.cgi?id=181771&action=review

------- Additional Comments from James Robinson <jamesr at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=181771&action=review


> Source/WebCore/page/scrolling/ScrollingCoordinator.cpp:188
> +	   if (!r.isEmpty()) {

whole lotta' indentation here. can we get some early returns?


More information about the webkit-reviews mailing list