[webkit-reviews] review denied: [Bug 105994] Check for git-svn so further commands don't die with strange error messages. : [Attachment 181143] Patch

[bugzilla-daemon at webkit.org]

Dirk Pranke <dpranke at chromium.org> has denied Tim 'mithro' Ansell
<mithro at mithis.com>'s request for review:
Bug 105994: Check for git-svn so further commands don't die with strange error
messages.
https://bugs.webkit.org/show_bug.cgi?id=105994

Attachment 181143: Patch
https://bugs.webkit.org/attachment.cgi?id=181143&action=review

------- Additional Comments from Dirk Pranke <dpranke at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=181143&action=review


>> Tools/Scripts/webkitpy/common/checkout/scm/git.py:67
>> +	    self._check_git_svn()
> 
> git svn isn't strictly necessary for all webkit-patch operations.  For
example, I don't think the EWS bots have git-svn installed (since they never
need to talk to svn).  Maybe we should run this check before trying to use git
svn ?

Adam is right; we shouldn't require git-svn for everything, just for the things
that need it.