[webkit-reviews] review granted: [Bug 106463] PluginPackage::freeLibraryTimerFired asserts if plugin got loaded again meanwhile : [Attachment 181936] patch

[bugzilla-daemon at webkit.org]

Alexey Proskuryakov <ap at webkit.org> has granted David Faure <faure at kde.org>'s
request for review:
Bug 106463: PluginPackage::freeLibraryTimerFired asserts if plugin got loaded
again meanwhile
https://bugs.webkit.org/show_bug.cgi?id=106463

Attachment 181936: patch
https://bugs.webkit.org/attachment.cgi?id=181936&action=review

------- Additional Comments from Alexey Proskuryakov <ap at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=181936&action=review


Looks reasonable.

>> Source/WebCore/plugins/PluginPackage.cpp:71
>> +	if (m_loadCount == 0) {
> 
> Tests for true/false, null/non-null, and zero/non-zero should all be done
without equality comparisons.  [readability/comparison_to_zero] [5]

This is correct, please fix.