[webkit-reviews] review granted: [Bug 106137] REGRESSION(r138222): WebDocumentLoaderMac-related leaks seen on Leaks bot : [Attachment 181942] Without the class variable

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Jan 9 16:40:11 PST 2013


Brady Eidson <beidson at apple.com> has granted Nate Chapin
<japhet at chromium.org>'s request for review:
Bug 106137: REGRESSION(r138222): WebDocumentLoaderMac-related leaks seen on
Leaks bot
https://bugs.webkit.org/show_bug.cgi?id=106137

Attachment 181942: Without the class variable
https://bugs.webkit.org/attachment.cgi?id=181942&action=review

------- Additional Comments from Brady Eidson <beidson at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=181942&action=review


> Source/WebCore/loader/MainResourceLoader.cpp:103
> +    if (m_substituteDataLoadIdentifier)
> +	   frameLoader()->client()->dispatchDidFailLoading(documentLoader(),
m_substituteDataLoadIdentifier, error);

Would like to see ASSERT(!loader()) in here.


More information about the webkit-reviews mailing list