[webkit-reviews] review granted: [Bug 106257] [WK2] Set IndexedDB database path in WK2 : [Attachment 181827] Patch

[bugzilla-daemon at webkit.org]

Benjamin Poulain <benjamin at webkit.org> has granted Michael Pruett
<michael at 68k.org>'s request for review:
Bug 106257: [WK2] Set IndexedDB database path in WK2
https://bugs.webkit.org/show_bug.cgi?id=106257

Attachment 181827: Patch
https://bugs.webkit.org/attachment.cgi?id=181827&action=review

------- Additional Comments from Benjamin Poulain <benjamin at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=181827&action=review


It is not ideal but I think that looks okay to bootstrap IndexedDB. It will
probably evolve separately.

> Source/WebKit2/WebProcess/WebPage/WebPageGroupProxy.cpp:71
> +    WebKeyValueStorageManager& keyValueStorageManager =
*WebProcess::shared().supplement<WebKeyValueStorageManager>();
> +   
m_pageGroup->groupSettings()->setIndexedDBDatabasePath(keyValueStorageManager.i
ndexedDBDatabaseDirectory());

Please don't do the pointer-to-reference conversion. Just use the pointer
directly.