[webkit-reviews] review granted: [Bug 93979] [WK2] Implement eventSender.scheduleAsynchronousKeyDown : [Attachment 181870] Patch

[bugzilla-daemon at webkit.org]

Benjamin Poulain <benjamin at webkit.org> has granted Christophe Dumez
<christophe.dumez at intel.com>'s request for review:
Bug 93979: [WK2] Implement eventSender.scheduleAsynchronousKeyDown
https://bugs.webkit.org/show_bug.cgi?id=93979

Attachment 181870: Patch
https://bugs.webkit.org/attachment.cgi?id=181870&action=review

------- Additional Comments from Benjamin Poulain <benjamin at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=181870&action=review


Looks good.
One comment but it is not blocking:

> Tools/WebKitTestRunner/TestController.cpp:815
> +	      
didReceiveKeyDownMessageFromInjectedBundle(messageBodyDictionary, false);

You can avoid this kind of code by using a enum instead of a boolean
    didReceiveKeyDownMessageFromInjectedBundle(messageBodyDictionary,
SendSynchronously);
    didReceiveKeyDownMessageFromInjectedBundle(messageBodyDictionary,
SendAsynchronously);