[webkit-reviews] review denied: [Bug 104600] [Chromium] Always enable autocomplete for password fields : [Attachment 181976] Patch

[bugzilla-daemon at webkit.org]

Tony Chang <tony at chromium.org> has denied Yue Zhang <zysxqn at chromium.org>'s
request for review:
Bug 104600: [Chromium] Always enable autocomplete for password fields
https://bugs.webkit.org/show_bug.cgi?id=104600

Attachment 181976: Patch
https://bugs.webkit.org/attachment.cgi?id=181976&action=review

------- Additional Comments from Tony Chang <tony at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=181976&action=review


> Source/WebKit/chromium/ChangeLog:6
> +	   https://bugs.webkit.org/show_bug.cgi?id=104600
> +
> +	   Don't check autocomplete in webkit code. Rather, we check it in
chrome code in the following way: if the password field is chrome generated
password, we ignore autocomplete=off and always fill the password; otherwise,
we respect the autocomplete set. Since this is a chrome only feature, we make
it configurable (default to false but enable this in chrome code).

Sorry, I mean to remove the WebCore/ChangeLog file.  You still need the
"Reviewed by NOBODY (OOPS!)." line so the tools can fill in the actual
reviewer.  You can also write "Reviewed by Darin Fisher." since he gave an r+
on an earlier patch.