[webkit-reviews] review granted: [Bug 106476] Replace unnecessary null-checks with an assert in MainResourceLoader::continueAfterNavigationPolicy : [Attachment 181957] patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Wed Jan 9 12:51:38 PST 2013
Alexey Proskuryakov <ap at webkit.org> has granted Nate Chapin
<japhet at chromium.org>'s request for review:
Bug 106476: Replace unnecessary null-checks with an assert in
MainResourceLoader::continueAfterNavigationPolicy
https://bugs.webkit.org/show_bug.cgi?id=106476
Attachment 181957: patch
https://bugs.webkit.org/attachment.cgi?id=181957&action=review
------- Additional Comments from Alexey Proskuryakov <ap at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=181957&action=review
> Source/WebCore/loader/MainResourceLoader.cpp:192
> + ASSERT(resourceLoader &&
resourceLoader->shouldSendResourceLoadCallbacks());
Please break this into two lines, to make it easier to know which part failed.
I'm still unconvinced that we need to assert that resourceLoader is not null
though.
More information about the webkit-reviews
mailing list