[webkit-reviews] review denied: [Bug 106374] REGRESSION(r136967): margin-top + overflow:hidden causes incorrect layout for internal floated elements : [Attachment 181952] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Jan 9 12:47:15 PST 2013


Dave Hyatt <hyatt at apple.com> has denied Robert Hogan <robert at webkit.org>'s
request for review:
Bug 106374: REGRESSION(r136967): margin-top + overflow:hidden causes incorrect
layout for internal floated elements
https://bugs.webkit.org/show_bug.cgi?id=106374

Attachment 181952: Patch
https://bugs.webkit.org/attachment.cgi?id=181952&action=review

------- Additional Comments from Dave Hyatt <hyatt at apple.com>
This will break the case where the overflow:hidden self-collapsing block
legitimately has to clear a float because it doesn't fit, etc. This is the
reason we don't just check style()->clear(), since you can clear for other
reasons besides just having the style set. The more interesting question to me
is why this block is claiming that it has clearance when it obviously
shouldn't.


More information about the webkit-reviews mailing list