[webkit-reviews] review requested: [Bug 88961] [GTK][EFL] http/tests/misc/redirect-to-about-blank.html is failing : [Attachment 181967] updated for comments
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Wed Jan 9 12:15:23 PST 2013
Dan Winship <danw at gnome.org> has asked for review:
Bug 88961: [GTK][EFL] http/tests/misc/redirect-to-about-blank.html is failing
https://bugs.webkit.org/show_bug.cgi?id=88961
Attachment 181967: updated for comments
https://bugs.webkit.org/attachment.cgi?id=181967&action=review
------- Additional Comments from Dan Winship <danw at gnome.org>
> I think it makes sense to put this into a helper function for the benefit of
readability.
not totally sure that this was an improvement, given the completely random
assortment of parameters we have to pass to it...
> Maybe cleanupSoupRequestOperation should be part of
createSoupRequestAndMessageForHandle now?
Well, the other place that calls createSoupRequestAndMessageForHandle() doesn't
need it...
More information about the webkit-reviews
mailing list